Notable issues and merges on Bitcoin Core, LND and c-lightning.
Bitcoin Core #14248 and #14249:
This was a fix to a denial-of-service vulnerability (CVE-2018-17144) exploitable by miners that has been discovered in Bitcoin Core versions 0.14.0 up to 0.16.2. It is recommended to upgrade any of the vulnerable versions to 0.16.3 as soon as possible. The fix was backported to the 0.16 branch.
Bitcoin Core #7965:
This week a long-standing issue that tracked the removal of code handling
whether the wallet is compiled in the
libbitcoin_server component was closed
by the merge of #14168.
This issue is part of an ongoing long-term effort to separate the wallet related code from the server code, along with a number of issues such as #10973(separate wallet from node whose PR is still being reviewed) and #14180(Run all tests even if wallet is not compiled) which will provide many benefits such as easier code maintenance, more straightforward way to test individual components and overall could help for a more secure software if the wallet component is moved to its own process.
The configuration option
--noencryptwallet that was originally intended only for
testing has been renamed to
--noseedbackup and has been marked as deprecated. The
help text for the option has been updated to mostly uppercase warning text:
If true, NO SEED WILL BE EXPOSED AND THE WALLET WILL BE ENCRYPTED USING THE DEFAULT PASSPHRASE – EVER. THIS FLAG IS ONLY FOR TESTING AND IS BEING DEPRECATED.
This is intended for for users who might be using this option without realizing the real risk of losing money when using it.
NOTE: Any users that are actively using
noencryptwalletwill have to switch any scripts/confs to use
noseedbackupas a result of this PR, though no further modification should be required.
This merge adds support for the v3 onion services available through Tor’s control port available since Tor v0.3.3.6. This will allow LND to automatically create and set up v3 onion services in addition to its exsiting v2 automation. For this to work users must have a running Tor service along side LND.
A series of patches that improve the cli and its help command by showing the
command usage in the output. It also allows to verify a command without running
it by using the
lightning-cli check newaddr bech32
The above will check the parameter but won’t create a new address. It will just respond with “ok”.