## XRP fixes Fixes XRP pending operation to have a wrong transaction hash displayed also causing the Operation Detail modal to disappear a few second after broadcast. ## Bitcoin coin control features ### Changes - transactions are no longer RBF enabled. - by default, unconfirmed RBF are excluded. - we have finer coin control. ### QA implications - must carefully test bitcoin and its forks and especially Send flow. This is especially relevant as the total to spend / amount / error validation have changed its logic. - use coin control feature as a way to test more transaction scenarios but don't test the feature itself, it's a dev only thing for now until we make it stable. (only consider testing what user will see with the checkbox) ### Type additions in live-common model - Account#bitcoinResources.utxos - TransactionStatus#txInputs - TransactionStatus#txOutputs - Transaction#utxoStrategy ### CLI options - transaction commands have a `--excludeUTXO, -E` that allows to exclude specific utxo (format is `hash@index`) - transaction commands have a `--rbf` that allows to enable rbf - transaction commands have a `--bitcoin-picking-strategy` that allows to change the picking strategy - account formatter will display the utxo list, up to DEBUG_UTXO_DISPLAY items. (set to a low 4 at the moment) - status formatter will display the inputs / outputs ### bot benefit the better formatting ``` ▬ BitcoinCash 1.4.2 on nanoS 1.6.1-rc1 → FROM Bitcoin Cash 1: BCH 0.009973 (251ops) (15CPMSZxwNCdzsHgktAKhYeo2pbH17vNhM on 44'/145'/0'/0/128) #0 xpub6CbdHiHA7R6VATXLiGDgidcx2VAmrMZnHq7c6eqGVgaDQe5aS2jyW2F7c2vTbiyG6XeS547DGZc7u3wA4jHUamMas4WVtENyxLWv1eSezWA 3 UTXOs 0.00562 1BKdSpCVhNkRkbxLaHDVX6WT4uHfkPH346 9ca70ea4da8fc7c5781b5d5a1648bf86fc5906d255cf97f10ac45dcaf2d3dc9b @0 (10) 0.0028446 1MDXDF2ACyswTxVXqNiGpQeN2AikyQaNZe e5e25edd8331366d314509cad6542cf870bbc709bfc55d3f6a4f806535c0d83c @0 (9) 0.0015083 1AesUoJSgc6N23C6839G477PLLE66odoKW 646476ae10339fa4a87c35177a0b5143860bccfb1d3ccbc48e09eb0262ce2364 @0 (29) max spendable ~0.009968 ★ using mutation 'optimize-size' → TO Bitcoin Cash 2: BCH 0.0005062 (241ops) (1VYP2RDwTTLm9M3mDTFgRtfQbuuQnyYrS on 44'/145'/1'/0/113) #1 xpub6CbdHiHA7R6VBbcqmQoKK2CJDZpnfvofQamDeniLhH3Hkrs449jJvBvUpVdLBddUvVtTj2kWSmvdBenFjYo5wwv7poYkEvftBP1R8rdAYSM ✔️ transaction SEND BCH 0.00740702 TO 1VYP2RDwTTLm9M3mDTFgRtfQbuuQnyYrS with feePerByte=1 (network fees: 0=1, 1=1, 2=1) OPTIMIZE_SIZE STATUS (4.7s) TX INPUTS (2): 0.00562 1BKdSpCVhNkRkbxLaHDVX6WT4uHfkPH346 9ca70ea4da8fc7c5781b5d5a1648bf86fc5906d255cf97f10ac45dcaf2d3dc9b@0 0.0028446 1MDXDF2ACyswTxVXqNiGpQeN2AikyQaNZe e5e25edd8331366d314509cad6542cf870bbc709bfc55d3f6a4f806535c0d83c@0 TX OUTPUTS (2): 0.007407 1VYP2RDwTTLm9M3mDTFgRtfQbuuQnyYrS rbf @0 (0) 0.0010539 1HiJPYVSmJqVq8eEFsoxnf1vxP29XwbSGm 44'/145'/0'/1/61 rbf @1 (0) amount: BCH 0.00740702 estimated fees: BCH 0.00000374 total spent: BCH 0.00741076 ✔️ has been signed! (12.8s) ✔️ broadcasted! (2844ms) optimistic operation: - BCH 0.00741076 OUT 3cbb64a0f93a501dc479673594ce5eb04f7c9f682451d3475cb81219f736711f 2020-06-28T15:41 ✔️ operation confirmed (38.4s): - BCH 0.00741076 OUT 3cbb64a0f93a501dc479673594ce5eb04f7c9f682451d3475cb81219f736711f 2020-06-28T15:42 ✔️ Bitcoin Cash 1: BCH 0.0025622 (252ops) (15CPMSZxwNCdzsHgktAKhYeo2pbH17vNhM on 44'/145'/0'/0/128) #0 xpub6CbdHiHA7R6VATXLiGDgidcx2VAmrMZnHq7c6eqGVgaDQe5aS2jyW2F7c2vTbiyG6XeS547DGZc7u3wA4jHUamMas4WVtENyxLWv1eSezWA 2 UTXOs 0.0015083 1AesUoJSgc6N23C6839G477PLLE66odoKW 646476ae10339fa4a87c35177a0b5143860bccfb1d3ccbc48e09eb0262ce2364 @0 (29) 0.0010539 1HiJPYVSmJqVq8eEFsoxnf1vxP29XwbSGm 3cbb64a0f93a501dc479673594ce5eb04f7c9f682451d3475cb81219f736711f @1 (0) (final state reached in 38.3s) ```